ro marked 2 inline comments as done. ro added inline comments.
================ Comment at: clang/test/Driver/solaris-ld-sanitizer.c:1 +// General tests that the ld -z relax=transtls workaround is only applied +// on Solaris/amd64. Note that we use sysroot to make these tests ---------------- MaskRay wrote: > Optional: some folks prefer an alternative comment marker (`///` for C, `##` > for assembly, etc) for non-RUN non-CHECK comments. It makes the comments > stand out (they may render differently in an editor). Many tests have > check-prefix typos and if we teach lit or FileCheck to catch such typos, we > can let them skip `///` lines to avoid false positives. Seems quite sensible: patch amended. ================ Comment at: clang/test/Driver/solaris-ld-sanitizer.c:6 +// Check sparc-sun-solaris2.11, 32bit +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// RUN: --target=sparc-sun-solaris2.11 \ ---------------- MaskRay wrote: > Remove -no-canonical-prefixes . See some cleanup advice on D119309. Done, as well as `-o %t.o`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D119829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
