tbaeder marked an inline comment as done. tbaeder added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:54 +------------------ +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array ---------------- aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > Just added a reference to the bug that was fixed. > > I was wondering about this. Where does the "PRXXXXXX" syntax come from? > > Since the repo and issues are on github now, I don't see how it makes sense > > to call it a PR (it's an issue, not a pull request) and github doesn't > > linkify those, while it does when using the `#xxxxxx` syntax (which isn't > > relevant in this case, but it is when using it in git commit messages). I > > have seen other people use the same syntax to refer to issues. I'd probably > > just add an actual link to the github issue here if that's permitted. > > Thanks for the suggestion though, I'm on PTO this week so don't land this > > until Monday :) > > I was wondering about this. Where does the "PRXXXXXX" syntax come from? > > "Problem Report" -- ancient terminology. > > > I have seen other people use the same syntax to refer to issues. I'd > > probably just add an actual link to the github issue here if that's > > permitted. > > TBH, I think that's an even better suggestion (linking to the issue). One > concern I have is that it's really hard to tell whether the number is a > bugzilla issue number or a GitHub issue number (I suppose we should all > assume they're always github issue numbers these days though), so I wasn't > keen on having a number with no prefix to it. But if we're linking to what's > been fixed, then there's never a chance for confusion. > > > Thanks for the suggestion though, I'm on PTO this week so don't land this > > until Monday :) > > Sounds good to me, enjoy your PTO! I added a link for the new entry and replaced the old PR mention with a link as well, so it's consistent at least. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
