tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:11556 X = ThenBO->getLHS(); - D = ThenBO->getRHS(); + D = ThenBO->getRHS()->IgnoreImpCasts(); ---------------- ABataev wrote: > Need to be careful here, probably may need to cast to resulting type > explicitly to avoid problems between int/float/etc. conversions. I think we don't need that as `D` and `E` are supposed to be rvalue, and as shown here I only ignore implicit casts for rvalue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
