awarzynski added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:4815 -} +} // let Flags = [CC1Option, CC1AsOption, NoDriverOption] + ---------------- schweitz wrote: > Is this comment something left over from edits? This is intentional (there's already a [[ https://github.com/llvm/llvm-project/blob/650aec687eb54aeeb3cef4a41f2dbaa49ef3e358/clang/include/clang/Driver/Options.td#L6009 | precedent ]] in this file). The nesting of `let` statements in this file can be very confusing. Also, some `let` blocks are really large. I think that adding such comments helps to separate them visually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
