zequanwu added inline comments.
================
Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:86
+ "int j;\n"
+ "}// namespace A::M",
+ fixNamespaceEndComments("#define M(x) x##x\n"
----------------
MyDeveloperDay wrote:
> same here its not A::M is it? at best its A::x but it depends on the macro ?
> or have I miss understood?
Yes, you are right. Fixed to include the macro literally.
Ideally, it should expand the macro to get the name or ignore the macro.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120931/new/
https://reviews.llvm.org/D120931
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
