alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
Looks good with a couple of nits. ================ Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:808 @@ +807,3 @@ + addUsage(NamingCheckFailures, ID, Range); + return; +} ---------------- `return`? ================ Comment at: clang-tidy/readability/IdentifierNamingCheck.h:94 @@ -86,1 +93,3 @@ + /// Check Macros for style violations + void checkMacro(SourceManager &sourceMgr, const Token &MacroNameTok, ---------------- Please add trailing periods to comments. See also http://llvm.org/docs/CodingStandards.html#commenting http://reviews.llvm.org/D21020 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits