RKSimon added a comment. In D117829#3386398 <https://reviews.llvm.org/D117829#3386398>, @fhahn wrote:
> @RKSimon are you planning on pushing this patch through? From my perspective, > it looks good with splitting off `__builtin_reduce_mul` and adding a TODO to > also implement it for floating point types. You mean handle add/mul in separate patches? I'm happy to continue with this, I just didn't want to make it more difficult for us to add fp support in the future - particularly if we do end up needing the scalar initial_value argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
