LegalizeAdulthood added a comment. I think I've got all the changes incorporated, but I'm getting a test failure so I haven't uploaded a new diff.
Honestly, I don't understand the test failure output. On Windows, the test failure output is all mangled and difficult to interpret correctly as to what exactly is the problem, so I'm still trying to figure it out. Improving the readability of the test failures is one of the things I would like to address in a future change. I suspect it's only a problem on Windows as it seems most of the clang-tidy devs are using unix? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits