Manna added a comment. In D119017#3392984 <https://reviews.llvm.org/D119017#3392984>, @devin.jeanpierre wrote:
> In D119017#3392961 <https://reviews.llvm.org/D119017#3392961>, @Manna wrote: > >> LIT test (SemaCXX/attr-trivial-abi.cpp) is failing for x86 build of clang. >> The same failures are happening with our downstream X86 clang build. >> [...] >> The test might need to be updated so that shouldn't run with x86 build. >> @devin.jeanpierre, could you please look at the test failures? Thanks > > A couple questions -- was that failure introduced by this change, or a > different change? Also, what target triple, so that I can reproduce? (New to > clang development...) > > (I am hoping that I'm not expected to roll back this change after it's been > in for a month.) Thanks for the quick response! >> was that failure introduced by this change, or a different change? Yes, the failures were introduced by this change. >> lf so, what target triple, so that I can reproduce? (New to clang >> development...) You can reproduce the test failure if you checkout 32 bit clang compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119017/new/ https://reviews.llvm.org/D119017 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
