simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land.
Whereas I'm familiar with this code but not with the opaque-pointers effort, so I had to look up the //other// half of what was going on :-) If I've understood this correctly, the point is that we should no longer be looking inside a pointer-typed `llvm::Value` to find out its pointee type, because at some point in the future it will stop storing one at all? And therefore the codegen layer above, if it wants to know the pointee type for a `Value` it's already made, has to take responsibility for remembering it itself from the point where the `Value` was constructed. This seems fine to me, and the uses of `address` in the actual `arm_mve.td` don't look as if they're likely to cause trouble with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122046/new/ https://reviews.llvm.org/D122046 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
