NoQ added a comment. Looks like the API was used incorrectly 50% of the time anyway :)
I have one nit but other than that looks good. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2570 + State, TotalSize.castAs<DefinedOrUnknownSVal>(), + svalBuilder.makeIntValWithPtrWidth(Arg1->getType(), 0)); ---------------- steakhal wrote: > We peobably wanted to use a different tspe for this expressuon. > 'getArrayIndexType()' is a better fit IMO. > We shall see. `TotalSize` is literally `size_t` so `ASTContext.getSizeType()` is the right type. `getArrayIndexType()` is signed so it's different. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
