urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land.
looks resonable, 1 nit. ================ Comment at: clang/lib/Driver/Driver.cpp:2453 // Disambiguate headers that are meant to be header units from those - // intended to be PCH. - if (Ty == types::TY_CXXHeader && hasHeaderMode()) + // intended to be PCH. Avoid missing '.h' cases that are counted as + // C headers by default - we know we are in C++ mode and we do not ---------------- extra whitespace 'are[spc][spc]counted' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121590/new/ https://reviews.llvm.org/D121590 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits