curdeius added a comment.

In D121451#3401947 <https://reviews.llvm.org/D121451#3401947>, @MyDeveloperDay 
wrote:

> I'm a little uncomfortable with
>
>   //#<preprocessor directive>
>
> becoming
>
>   // #<preprocessor directive>
>
> At least without an option for it to not make changes

Don't you think that `//#PPdirective` should be indented the same way as other 
code?
E.g. in:

  #include <header.h>
  
  int something;

You comment the whole block and it becomes (with this patch):

  // #include <header.h>
  //
  // int something;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121451/new/

https://reviews.llvm.org/D121451

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to