Prazek added a comment.

In http://reviews.llvm.org/D20964#453797, @vsk wrote:

> @Eugene.Zelenko thanks for pointing this out, I had totally missed this 
> patch! Once we get this reviewed I'm willing to abandon my version. Some 
> comments inline --


I have tested it on llvm code base and I have found many, many corner cases. I 
see that your check have better fixit messages (it only prints change of 
push_back -> emplace_back). I guess the best idea is to push this check, and 
then if you would like, change it so it would also have nice fixit messages


http://reviews.llvm.org/D20964



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to