iains created this revision.
Herald added a project: All.
iains added a reviewer: urnathan.
iains published this revision for review.
iains added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
somewhat on the trivial side.
When adding the support for modules partitions we added an assert that the
actual status of Global Module Fragments matches the state machine that is
driven by the module; keyword.
That does not apply to the modules-ts case, where there is an implicit GMF.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D122394
Files:
clang/lib/Sema/SemaModule.cpp
Index: clang/lib/Sema/SemaModule.cpp
===================================================================
--- clang/lib/Sema/SemaModule.cpp
+++ clang/lib/Sema/SemaModule.cpp
@@ -173,7 +173,7 @@
ModuleScopes.back().Module->Kind == Module::GlobalModuleFragment)
GlobalModuleFragment = ModuleScopes.back().Module;
- assert((!getLangOpts().CPlusPlusModules ||
+ assert((!getLangOpts().CPlusPlusModules || getLangOpts().ModulesTS ||
SeenGMF == (bool)GlobalModuleFragment) &&
"mismatched global module state");
Index: clang/lib/Sema/SemaModule.cpp
===================================================================
--- clang/lib/Sema/SemaModule.cpp
+++ clang/lib/Sema/SemaModule.cpp
@@ -173,7 +173,7 @@
ModuleScopes.back().Module->Kind == Module::GlobalModuleFragment)
GlobalModuleFragment = ModuleScopes.back().Module;
- assert((!getLangOpts().CPlusPlusModules ||
+ assert((!getLangOpts().CPlusPlusModules || getLangOpts().ModulesTS ||
SeenGMF == (bool)GlobalModuleFragment) &&
"mismatched global module state");
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
