jyu2 added a comment.

In D122338#3405948 <https://reviews.llvm.org/D122338#3405948>, @ABataev wrote:

> LG

Thank you so much Alexey.



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11988
         if (isa<CXXThisExpr>(E)) {
           Pos = ParamPositions[FD];
         } else {
----------------
ABataev wrote:
> I would also recommend to replace all `operator []` calls to something that 
> does not modify the map, like `find`.
How about adding assert?  Thanks.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122338/new/

https://reviews.llvm.org/D122338

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to