owenpan added a comment.
In D121756#3398165 <https://reviews.llvm.org/D121756#3398165>, @sstwcw wrote:
> It turned out this patch does change behavior.
>
> - while (
> - FormatTok->isOneOf(tok::identifier, tok::kw_requires,
> tok::coloncolon)) {
> + while (FormatTok->isOneOf(tok::identifier, tok::kw_requires,
> + tok::coloncolon)) {
>
> So what do I do?
IMO, refactoring and cleaning up code should be NFC. You can first add `while`,
`switch`, etc (if it makes sense) in one patch and then refactor in another
patch (or vice versa). It would be much easier to review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121756/new/
https://reviews.llvm.org/D121756
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
