aaron.ballman added a comment.

I think this is a sufficient stopgap measure to keep clang from crashing, and I 
appreciate the FIXME comment. Should the cxx_status page also be updated, or is 
P0315R4 still partial (and if it is, can we add information to the status page 
about what's partial if you know it)? Also, this could use a release note about 
the fixes. So almost LGTM!



================
Comment at: clang/lib/Sema/TreeTransform.h:12934
+  // substituting an unevaluated lambda inside of a function's parameter's type
+  // - as parameter type are not instanciated from within a function's DC. We
+  // use isUnevaluatedContext() to distinguish the function parameter case.
----------------
aaron.ballman wrote:
> 
Still need to fix the typos here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121532/new/

https://reviews.llvm.org/D121532

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to