mstorsjo added inline comments.
================ Comment at: clang-tools-extra/test/CMakeLists.txt:84 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) - llvm_add_library( - CTTestTidyModule - MODULE clang-tidy/CTTestTidyModule.cpp - PLUGIN_TOOL clang-tidy - DEPENDS clang-tidy-headers) + if (NOT WIN32 AND NOT LLVM_LINK_LLVM_DYLIB) + llvm_add_library( ---------------- jeremyd2019 wrote: > I only just noticed this patch, but it feels to me like this was intended to > be OR here, because the condition to be avoided seems to be `WIN32 AND > LLVM_LINK_LLVM_DYLIB`, which inverted is `NOT WIN32 OR NOT > LLVM_LINK_LLVM_DYLIB` Oh indeed, thanks, good catch! I'll push a patch fixing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121687/new/ https://reviews.llvm.org/D121687 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
