rs added a comment.

In D122712#3416238 <https://reviews.llvm.org/D122712#3416238>, @benshi001 wrote:

> I do not like this change, since
>
> 1. actually there may be many kinds of warnings emitted by the 
> clang-driver-avr depending on different options, and this single line `// 
> NOWARN-NOT: warning:` means non of these possible warnings will be emitted.
>
> 2. we may add/delete/modify warnings in the future, so we should not make it 
> specific .

ok fair enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122712/new/

https://reviews.llvm.org/D122712

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to