Prazek added inline comments.

================
Comment at: clang-tidy/performance/ReturnValueCopyCheck.cpp:107-108
@@ +106,4 @@
+                       InnerMatcher) {
+  return hasDeclaration(
+      cxxRecordDecl(hasDescendant(cxxConstructorDecl(InnerMatcher))));
+}
----------------
You have bug here, but it should not affect the check - 
hasDescendant(cxxConstructorDecl()) could possibly match to constructor of 
another class defined inside class.

Try
cxxRecordDecl(hasMethod(cxxConstructorDecl(InnerMatcher))))


http://reviews.llvm.org/D21303



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to