erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Basic/Attr.td:2730 + // used for the "default" variant be the largest mangling ID in the + // variant set. Note that, if duplicate variants are present in + // 'featuresStrs', that each instance will be assigned its own unique ---------------- this comma doesn't read right to me, I don't think it is required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122955/new/ https://reviews.llvm.org/D122955 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits