zixuw marked an inline comment as done.
zixuw added inline comments.
================
Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:396
break;
+ case APIRecord::RK_ObjCCategory:
+ Kind["identifier"] = AddLangPrefix("category");
----------------
dang wrote:
> Since we currently never actually emit a standalone category symbol object,
> should we not just label this as `llvm_unreachable` with a comment explaining
> why that is?
Yep, makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122774/new/
https://reviews.llvm.org/D122774
STAMPS
actor(@zixuw) application(Differential) author(@zixuw) herald(H423)
herald(H576) herald(H864) herald(H875) monogram(D122774) object-type(DREV)
phid(PHID-DREV-o2c75ab3w5lvo3s7frw5) reviewer(@dang) reviewer(@QuietMisdreavus)
reviewer(@ributzka) revision-repository(rG) revision-status(needs-review)
subscriber(@cfe-commits) tag(#all) tag(#clang) via(web)
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
