[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang

[Brad Smith via Phabricator via cfe-commits]

brad created this revision.
brad added a reviewer: kito-cheng.
brad added a project: clang.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, 
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, 
jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, 
zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, arichardson.
Herald added a project: All.
brad requested review of this revision.
Herald added subscribers: cfe-commits, pcwang-thead, eopXD, MaskRay.

Generic_GCC::IsIntegratedAssemblerDefault() already takes care of RISCV. Remove 
the redundant enabling of IAS with Clang.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123097

Files:
  clang/lib/Driver/ToolChains/RISCVToolchain.h


Index: clang/lib/Driver/ToolChains/RISCVToolchain.h
===================================================================
--- clang/lib/Driver/ToolChains/RISCVToolchain.h
+++ clang/lib/Driver/ToolChains/RISCVToolchain.h
@@ -22,7 +22,6 @@
                  const llvm::opt::ArgList &Args);
 
   static bool hasGCCToolchain(const Driver &D, const llvm::opt::ArgList &Args);
-  bool IsIntegratedAssemblerDefault() const override { return true; }
   void addClangTargetOptions(const llvm::opt::ArgList &DriverArgs,
                              llvm::opt::ArgStringList &CC1Args,
                              Action::OffloadKind) const override;


STAMPS
actor(@brad) application(Differential) author(@brad) herald(H208) herald(H254) 
herald(H255) herald(H259) herald(H263) herald(H277) herald(H278) herald(H288) 
herald(H300) herald(H303) herald(H310) herald(H311) herald(H313) herald(H322) 
herald(H349) herald(H351) herald(H352) herald(H354) herald(H356) herald(H371) 
herald(H376) herald(H423) herald(H447) herald(H449) herald(H465) herald(H477) 
herald(H480) herald(H485) herald(H515) herald(H519) herald(H524) herald(H563) 
herald(H576) herald(H686) herald(H696) herald(H721) herald(H825) herald(H826) 
herald(H843) herald(H849) herald(H856) herald(H864) herald(H888) 
monogram(D123097) object-type(DREV) phid(PHID-DREV-jjml2cj3psrp4dk2ehp7) 
reviewer(@kito-cheng) revision-repository(rG) revision-status(needs-review) 
subscriber(@apazos) subscriber(@arichardson) subscriber(@asb) 
subscriber(@benna) subscriber(@brucehoult) subscriber(@cfe-commits) 
subscriber(@edward-jones) subscriber(@eopXD) subscriber(@evandro) 
subscriber(@frasercrmck) subscriber(@Jim) subscriber(@jocewei) 
subscriber(@johnrusso) subscriber(@jrtc27) subscriber(@luismarques) 
subscriber(@luke957) subscriber(@MartinMosbeck) subscriber(@MaskRay) 
subscriber(@niosHD) subscriber(@pcwang-thead) subscriber(@PkmX) 
subscriber(@psnobl) subscriber(@rbar) subscriber(@rogfer01) 
subscriber(@s.egerton) subscriber(@sabuasal) subscriber(@sameer.abuasal) 
subscriber(@simoncook) subscriber(@sunshaoce) subscriber(@the_o) 
subscriber(@VincentWu) subscriber(@vkmr) subscriber(@zzheng) tag(#all) 
tag(#clang) via(web)


Index: clang/lib/Driver/ToolChains/RISCVToolchain.h
===================================================================
--- clang/lib/Driver/ToolChains/RISCVToolchain.h
+++ clang/lib/Driver/ToolChains/RISCVToolchain.h
@@ -22,7 +22,6 @@
                  const llvm::opt::ArgList &Args);
 
   static bool hasGCCToolchain(const Driver &D, const llvm::opt::ArgList &Args);
-  bool IsIntegratedAssemblerDefault() const override { return true; }
   void addClangTargetOptions(const llvm::opt::ArgList &DriverArgs,
                              llvm::opt::ArgStringList &CC1Args,
                              Action::OffloadKind) const override;

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits