void added a comment. In D121556#3440383 <https://reviews.llvm.org/D121556#3440383>, @MaskRay wrote:
> Windows test is still failing after the std::shuffle => llvm::shuffle change, > guess time for revert. > > ../../clang/unittests/AST/RandstructTest.cpp(165): error: Expected equality > of these values: > Expected > Which is: { "lettuce", "bacon", "mayonnaise", "tomato" } > getFieldNamesFromRecord(RD) > Which is: { "bacon", "lettuce", "mayonnaise", "tomato" } > [ FAILED ] StructureLayoutRandomization.MarkedRandomize (47 ms) > [----------] 1 test from StructureLayoutRandomization (47 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test suite ran. (47 ms total) > [ PASSED ] 0 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] StructureLayoutRandomization.MarkedRandomize > > 1 FAILED TEST > > ******************** > Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. > ******************** > Failed Tests (1): > Clang-Unit :: > AST/./ASTTests.exe/StructureLayoutRandomization.MarkedRandomize Did this fail after the test was removed? If not, then I don't appreciate you reverting my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits