ldionne added a comment.

I actually think that `[[no_unique_address]]` and 
`__attribute__((no_unique_address))` should be equivalent. Similarly, we should 
be able to do `[[msvc::no_unique_address]]` and 
`__attribute__((msvc::no_unique_address))`, and both should be equivalent. 
Which one we pick for use in libc++ is a different issue, and we do it through 
a macro anyway so that we could easily change it in the future if we wanted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122874/new/

https://reviews.llvm.org/D122874

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to