hans added a comment. In D122766#3450298 <https://reviews.llvm.org/D122766#3450298>, @ayzhao wrote:
> So, the general consensus seems to be that we should use backslashes when > targeting Windows. > > I implemented using only backslashes for Windows; however, > clang/test/SemaCXX/destructor.cpp > <https://github.com/llvm/llvm-project/blob/main/clang/test/SemaCXX/destructor.cpp> > fails when running on Linux with the following error (among other errors, > but the one below is the most important). > > ... > error: 'error' diagnostics seen but not expected: > Line 32: > '<REDACTED_PATH_TO_LLVM_CHECKOUT_WITH_BACKSLASHES>\\clang\\test\\SemaCXX\\destructor.cpp' > file not found > ... > > The reason for this is that the test has Clang target windows > <https://github.com/llvm/llvm-project/blob/77d2c815f50b20d18f1207e4f442e2cf8eb8cec0/clang/test/SemaCXX/destructor.cpp#L2> > and the test also has the statement #include __FILE__ > <https://github.com/llvm/llvm-project/blob/77d2c815f50b20d18f1207e4f442e2cf8eb8cec0/clang/test/SemaCXX/destructor.cpp#L32>. That seems like an unusual use case of `__FILE__`. I wonder if we could just change the test to `#include "destructor.cpp"` instead and not worry about the case of `#include __FILE__` in cross-builds targeting Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
