jhuber6 added a comment. In D123812#3459164 <https://reviews.llvm.org/D123812#3459164>, @yaxunl wrote:
> need a CodeGenCUDA test for the registering. Also need a Driver test for the > subcommands. Testing things inside the linker wrapper is a little hairy. I may need to add a special option for doing dry runs and printing the wrapping code to we can test this more satisfactorily. Doing that will create some more noise for review unfortunately. For OpenMP is simply ran all of our unit tests using the new driver and considered that sufficient evidence that it was working. Also which driver sub-commands should be tested? In D123812#3459172 <https://reviews.llvm.org/D123812#3459172>, @yaxunl wrote: > Also, I am wondering whether we should document the new embedding scheme: > section names, symbol names, entries, etc, if it has not bee done. There's some existing documentation <https://clang.llvm.org/docs/OffloadingDesign.html> I wrote for OpenMP offloading once we started using this scheme. I was planning on updating it with this scheme for CUDA once it's landed, no sense writing documentation before it's final. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
