MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.h:495
+ Optional<llvm::Triple> getTargetVariantTriple() const override {
+ return TargetVariantTriple;
+ }
----------------
bc-lee wrote:
> MaskRay wrote:
> > llvm::None
> Do you mean to modify the method in `clang/include/clang/Driver/ToolChain.h`?
Ah, yes, `return llvm::Optional<llvm::Triple>();` Sorry for commenting on the
wrong place.
================
Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2
+// Run cc1as using darwin-target-variant-triple
+// RUN: %clang -cc1as -triple x86_64-apple-macos10.9
-darwin-target-variant-triple x86_64-apple-ios13.1-macabi -filetype obj %s -o -
\
+// RUN: | llvm-readobj --file-headers --macho-version-min - \
----------------
`-filetype obj` on the `%clang -cc1as` line seems weird.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121868/new/
https://reviews.llvm.org/D121868
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
