erichkeane planned changes to this revision.
erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2329
+ // constraint, so we should just create a copy of the previous one.
+ // TODO: ERICH: Should this be RebuildExprInCurrentInstantiation here?
+ if (!IsEvaluatingAConstraint()) {
----------------
I'm still not sure if anything should be rebuilt here, I suspect the answer is
MAYBE on the named-concept, but it isn't clear to me.
================
Comment at: clang/test/SemaTemplate/concepts.cpp:391
+
+ CausesFriendConstraint<int> CFC;
+ FriendFunc(CFC, 1);
----------------
erichkeane wrote:
> A bunch of the tests below this all fail.
See these two tests, which fail by saying that "::local is not a member of
class 'X'".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119544/new/
https://reviews.llvm.org/D119544
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
