erichkeane added a comment. In D122663#3471960 <https://reviews.llvm.org/D122663#3471960>, @hvdijk wrote:
> In D122663#3471866 <https://reviews.llvm.org/D122663#3471866>, @erichkeane > wrote: > >> This actually wouldn't be necessary in this case: cxxfilt is already >> 'right', this is just for humans to be able to see "we changed this from >> mangling as <obviously wrong> to <looks right>". > > That's a good point. We do have tests in clang that use llvm-cxxfilt already > (the PPC intrinsic tests) so there should be no problem with it as a > dependency; I think once this is in I might submit that as a follow-up change > for review unless someone else beats me to it. Any amount of test cleanup in that direction would be greatly appreciated! Even as NFC. The test I did it for was CodeGenCXX/mangle-nttp-anon-union.cpp as an example of what I'm talking about. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llvm.org/D122663 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
