tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
Wording nit. LGTM otherwise. ================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:113-114 def warn_drv_unsupported_option_for_offload_arch_req_feature : Warning< - "ignoring '%0' option as it is not currently supported for " - "offload arch '%1'. Use it with an offload arch containing '%2' instead">, + "ignoring '%0' option for offload arch '%1' as it is not currently supported for " + "that offload arch. Use it with an offload arch containing '%2' instead">, InGroup<OptionIgnored>; ---------------- 'there' would be more concise and less repetitive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124396/new/ https://reviews.llvm.org/D124396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
