aaron.ballman added a comment.

I went through the changes and they look correct to me... yet I'm still mildly 
terrified. :-D Have you tried running clang-tidy through its paces with 
ASan/MSan enabled to see if the change introduces any use-after-free issues in 
practice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124341/new/

https://reviews.llvm.org/D124341

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to