modimo added a comment. In D124563#3478627 <https://reviews.llvm.org/D124563#3478627>, @smeenai wrote:
> If I check out this commit and then check out the previous commit, > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp.expected` > become modified in my working directory; their line endings are changed from > CRLF to LF. That seems undesirable. Good catch, I see it as well. The `.gitattributes` change needs to be atomic with the renormalization change. If I checkout from main after the `.gitattributes` change (`git checkout ac5f7be6a868`) I'll see the files as dirty. However, if I checkout the revision before (`git checkout ac5f7be6a868~1`) this goes away. I think the way to go is to revert ac5f7be6a868 <https://reviews.llvm.org/rGac5f7be6a8688955a282becf00eebc542238a86b> then land everything as a single stack to prevent this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124563/new/ https://reviews.llvm.org/D124563 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
