junaire planned changes to this revision.
junaire added a comment.

> In general, my concern with the this patch is that it loses test coverage by 
> specifying an explicit language mode. We typically prefer to fix the tests so 
> that they can work in any language mode (and perhaps add additional RUN lines 
> in the process to do so).

OK, I'll do this. But I guess it is not sort of trivial work and will take 
plenty of time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124434/new/

https://reviews.llvm.org/D124434

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to