This revision was automatically updated to reflect the committed changes. Closed by commit rG52ce95a1a554: [NFC] Prevent shadowing a variable declared in `if` (authored by ken-matsui, committed by hubert.reinterpretcast).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 Files: clang/lib/Basic/Diagnostic.cpp Index: clang/lib/Basic/Diagnostic.cpp =================================================================== --- clang/lib/Basic/Diagnostic.cpp +++ clang/lib/Basic/Diagnostic.cpp @@ -983,13 +983,13 @@ if (const char *S = tok::getPunctuatorSpelling(Kind)) // Quoted token spelling for punctuators. Out << '\'' << S << '\''; - else if (const char *S = tok::getKeywordSpelling(Kind)) + else if ((S = tok::getKeywordSpelling(Kind))) // Unquoted token spelling for keywords. Out << S; - else if (const char *S = getTokenDescForDiagnostic(Kind)) + else if ((S = getTokenDescForDiagnostic(Kind))) // Unquoted translatable token name. Out << S; - else if (const char *S = tok::getTokenName(Kind)) + else if ((S = tok::getTokenName(Kind))) // Debug name, shouldn't appear in user-facing diagnostics. Out << '<' << S << '>'; else
Index: clang/lib/Basic/Diagnostic.cpp =================================================================== --- clang/lib/Basic/Diagnostic.cpp +++ clang/lib/Basic/Diagnostic.cpp @@ -983,13 +983,13 @@ if (const char *S = tok::getPunctuatorSpelling(Kind)) // Quoted token spelling for punctuators. Out << '\'' << S << '\''; - else if (const char *S = tok::getKeywordSpelling(Kind)) + else if ((S = tok::getKeywordSpelling(Kind))) // Unquoted token spelling for keywords. Out << S; - else if (const char *S = getTokenDescForDiagnostic(Kind)) + else if ((S = getTokenDescForDiagnostic(Kind))) // Unquoted translatable token name. Out << S; - else if (const char *S = tok::getTokenName(Kind)) + else if ((S = tok::getTokenName(Kind))) // Debug name, shouldn't appear in user-facing diagnostics. Out << '<' << S << '>'; else
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits