kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, lgtm! ================ Comment at: clang-tools-extra/clangd/ParsedAST.cpp:240 +// Note that unlike -Wunused, clang-diagnostics-unused does not imply +// subcategories like clang-diagnostics-unused function. +// ---------------- s/clang-diagnostics-unused function/clang-diagnostics-unused-function/ ================ Comment at: clang-tools-extra/clangd/ParsedAST.cpp:254 + TidyDiagnosticGroups(llvm::StringRef Checks) { + constexpr llvm::StringLiteral CDPrefix = "clang-diagnostic-"; + ---------------- `static constexpr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124679/new/ https://reviews.llvm.org/D124679 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits