dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.

Minor comment LGTM otherwise



================
Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:203
+    // Try to reduce the include name the same way we tried to include it.
+    if (auto IncludeName = getRelativeIncludeName(CI, FileName))
+      if (llvm::find(KnownFiles, *IncludeName) != KnownFiles.end()) {
----------------
Should we be tracking if the include was quoted or not? In principle, that 
could mean a different redirect in header search and therefore potentially 
mapping to different content.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123831/new/

https://reviews.llvm.org/D123831

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to