phyBrackets added inline comments.
================ Comment at: clang/include/clang/AST/ASTImporterLookupTable.h:17 +#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" // lookup_result ---------------- balazske wrote: > phyBrackets wrote: > > balazske wrote: > > > This include is not needed here. > > Hey thanks for reviewing , I have a doubt if I remove this include it from > > here , then I need to include this header in the ASTImporterSharedState.h , > > now the ASTImporterSharedState.h and ASTImporter.h both have > > ASTImportError.h included , isn't this affect on ASTImporter.cpp file on > > conflicting over ASTImportError ? Strangely it builds fine on my system tho > > . > > isn't this affect on ASTImporter.cpp file on conflicting over > > ASTImportError ? > This is no problem, this is why the include guard `#ifndef > LLVM_CLANG_AST_ASTIMPORTERROR_H` is there. > > ahh yes! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
