aaron.ballman added a comment. It looks like there's still something not quite right because it's warning on some instances but not others and I'm not certain why. Can you investigate?
================ Comment at: clang/test/Preprocessor/line-directive.c:33-34 # 42 "foo" 2 // expected-error {{invalid line marker flag '2': cannot pop empty include stack}} # 42 "foo" 1 3 // enter # 42 "foo" 2 3 // exit # 42 "foo" 2 3 4 // expected-error {{invalid line marker flag '2': cannot pop empty include stack}} ---------------- Something is still not quite correct -- these should also be diagnosed as an extension (it's the same feature just with flags). ================ Comment at: clang/test/Preprocessor/line-directive.c:61 # 192 "glomp.h" 3 // System header. typedef int y; // ok ---------------- This should also be diagnosed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits