jansvoboda11 marked 2 inline comments as done. jansvoboda11 added a comment.
In D121465#3384825 <https://reviews.llvm.org/D121465#3384825>, @vsapsai wrote: > My concern with this approach is I'm not sure if > `isEquivalentInternalLinkageDeclaration` is a desired long-term solution for > anonymous C++ enums. Is there anything suggesting it's not? ================ Comment at: clang/test/Modules/ambiguous-anonymous-enum-lookup.m.cpp:38 + +int testReferencingAnonymousEnumConstant() { + return kAnonymousEnumValue; // expected-no-diagnostics ---------------- vsapsai wrote: > Should we test also non-equivalent enums or is it tested somewhere else? I believe that's tested in `redefinition-c-tagtypes.m`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121465/new/ https://reviews.llvm.org/D121465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
