efriedma added a comment. We probably want testcases for accessing various parts of the stack frame with FP stored in r11; for example, can we correctly access arguments passed on the stack if there's stack realignment?
================ Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:242 + // Find last push instruction for GPRCS2 - spilling of high registers + // (r8-r11) could consist of multiple tPUSH and tMOVr instructions. + while (true) { ---------------- It seems sort of fragile to assume the entry block doesn't contain any tPUSH instructions; we can use them in places other than the prologue. Can we use the FrameSetup flag? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits