tra added a subscriber: tstellar. tra added a comment. LGTM in principle.
Given that we're introducing a new tool dependency we may want to get a stamp from someone dealing with build and release. @tstellar -- do we need to change anything else for the new binary to ship with clang releases? ================ Comment at: clang/docs/ClangOffloadBinary.rst:42 + + clang-offload-binary options: + ---------------- jhuber6 wrote: > tra wrote: > > This appears to be a one-way process. How one would examine what's in the > > binary and unpack/extract specific component from it? > This is done by the linker wrapper, but I think it would be good to teach > `llvm-objdump` how to handle these. Then we could basically just treat it the > same way as `cuobjdump`. SGTM. That may be a good motivation for someone to write a proper disassembler for NVIDIA's GPU binaries. Or we could teach it to invoke nvdisasm or cuobjdump if it sees an NVIDIA ELF file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125165/new/ https://reviews.llvm.org/D125165 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
