rnk added a comment.

This seems reasonable, but I worry about the consequences of creating lots of 
unnamed global variables. What will gdb do with so many unnamed globals? What 
will the PDB linker do with all these unnamed globals? I can't answer these 
questions, and you're welcome to try and find out, but I predict there will be 
problems, so just be aware of that possibility.

Looking at the S_GDATA32 record format, there is no place for the file & line 
info:
https://github.com/microsoft/microsoft-pdb/blob/master/include/cvinfo.h#L3629
It's just type info & name, really, so there's not much point in creating these 
when emitting codeview. It's probably best to filter these unnamed globals out 
in AsmPrinter/CodeViewDebug.cpp rather than changing the IR clang generates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123534/new/

https://reviews.llvm.org/D123534

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to