tianshilei1992 added inline comments.
================ Comment at: clang/lib/Basic/Targets/NVPTX.cpp:311 + } + return false; + } ---------------- `llvm_unreachable` might be more appropriate here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125350/new/ https://reviews.llvm.org/D125350 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits