void added a comment.
I'll split off the TableGen changes into a separate patch. It will supersede
those changes here, so it shouldn't delay other reviews here. :-)
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:798
+
+ if (STI.hasSVE()) {
+ for (MCRegister PReg :
----------------
nickdesaulniers wrote:
> Reuse `HasSVE` from L771?
Doh! Changed.
================
Comment at: llvm/test/CodeGen/AArch64/zero-call-used-regs.ll:2-3
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=aarch64-unknown-unknown | FileCheck %s
--check-prefix=DEFAULT
+; RUN: llc < %s -mtriple=aarch64-unknown-unknown -mattr=+sve | FileCheck %s
--check-prefix=SVE
+
----------------
nickdesaulniers wrote:
> If you use `--check-prefixes=CHECK,<unique>` (ie.
> `--check-prefixes=CHECK,DEFAULT` and `--check-prefixes=CHECK,SVE`) then when
> `DEFAULT` and `SVE` match, you can just use `CHECK`.
>
> That should help reduce the number of checks in this test significantly.
> Otherwise it's hard to tell what's different between the two cases, if
> anything at all.
>
> update_llc_test_checks should work with --check-prefixes IME.
What hath God wrought?!
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124836/new/
https://reviews.llvm.org/D124836
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
