jhenderson added a comment. Code change looks good to me. Are the TODO cases where the test fails if changing them?
================ Comment at: llvm/test/FileCheck/missspelled-directive.txt:18 + +P4_COUNT-2: foo +CHECK4: error: misspelled directive 'P4_COUNT-2:' ---------------- What about `P4-COUNT_2`? Is that case not really related? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits