nridge added a comment.
I looked through this patch, and it looks good to me! I will leave the final
approval to Sam though.
================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:416
+ // These mocks aren't quite right - we omit shared_ptr for simplicity.
+ // forward is included to show its body is not needed to get the
diagnostic.
+ template <typename T> T&& forward(T& t) { return static_cast<T&&>(t); }
----------------
I'm confused about this line: you say "show its body is not needed" but forward
has a body here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124688/new/
https://reviews.llvm.org/D124688
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
