LegalizeAdulthood added inline comments.

================
Comment at: 
clang-tools-extra/docs/clang-tidy/checks/performance-unused-no-side-effect.rst:172-173
+List of functions that are considered not to read some of their arguments
+unless their return value is read. Arguments are identified by a bitmask, where
+the i-th LSB being set indicates that the i-th argument is unused.
+
----------------
veluca93 wrote:
> LegalizeAdulthood wrote:
> > This isn't user-friendly at all.  Why not an array of argument indices 
> > starting at zero?
> Done. I'm using an empty array to indicate "everything", which is perhaps a 
> bit weird.
I think `[-1]` might be a better sentinel.  What do you do for functions that 
take zero arguments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124918/new/

https://reviews.llvm.org/D124918

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to