njames93 added a comment.
These tests aren't that great.
I'd advise adding a test that just checks using the userDefinedLiteral in
`bugprone-argument-comment-literals.cpp`, That check file will add comments to
parameters that don't have them.
That way you aren't testing against distinguishing between the actual parameter
comment and the literal comment.
This simple edit without your fix results in this diff in the output, with your
fix that diff wont exist.
[build] int operator""_op(unsigned long long Value);
[build]
[build] void test() {
[build] - 1_op;
[build] + /*Value=*/1_op;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125885/new/
https://reviews.llvm.org/D125885
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
